Skip to content

fix: DH-22054: GridMetrics type update#2659

Merged
mofojed merged 7 commits intodeephaven:mainfrom
ethanalvizo:type-updates
Apr 30, 2026
Merged

fix: DH-22054: GridMetrics type update#2659
mofojed merged 7 commits intodeephaven:mainfrom
ethanalvizo:type-updates

Conversation

@ethanalvizo
Copy link
Copy Markdown
Contributor

No description provided.

@ethanalvizo ethanalvizo self-assigned this Apr 9, 2026
@ethanalvizo ethanalvizo changed the title GridMetrics type update fix: GridMetrics type update Apr 9, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.74%. Comparing base (bdbf875) to head (3b8d81e).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/iris-grid/src/IrisGridUtils.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2659      +/-   ##
==========================================
- Coverage   49.76%   49.74%   -0.03%     
==========================================
  Files         774      774              
  Lines       43872    43884      +12     
  Branches    11295    11302       +7     
==========================================
- Hits        21835    21832       -3     
- Misses      21991    22006      +15     
  Partials       46       46              
Flag Coverage Δ
unit 49.74% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread packages/iris-grid/src/IrisGridCacheUtils.ts Outdated
@ethanalvizo ethanalvizo changed the title fix: GridMetrics type update fix: DH-22054: GridMetrics type update Apr 30, 2026
@ethanalvizo ethanalvizo requested a review from mofojed April 30, 2026 16:01
@mofojed mofojed merged commit c5426ec into deephaven:main Apr 30, 2026
12 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants